[hub] Sync safetensors Dtype union with upstream#2187
Merged
Conversation
Sync the `Dtype` union in parse-safetensors-metadata.ts with the upstream safetensors Rust enum. Adds: C64, F8_E4M3FNUZ, F8_E5M2FNUZ, F8_E8M0, U64, U32.
coyotte508
approved these changes
May 22, 2026
mishig25
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/hub/src/lib/parse-safetensors-metadata.ts:C64,F8_E4M3FNUZ,F8_E5M2FNUZ,F8_E8M0,U64,U32.pub enum Dtype).FP4,E8M0,UE8) in place — happy to remove them in a follow-up if they were not intentional.Test plan
Dtypeis only used asPartial<Record<Dtype, number>>and in narrowif (dtype === ...)checks, so adding variants is non-breaking.Note
Low Risk
Low risk type-only change that broadens supported safetensors
dtypevalues; behavior is unchanged aside from allowing additional variants in TypeScript checks.Overview
Updates the safetensors metadata parser’s
DtypeTypeScript union to include additional upstream dtype variants (C64,F8_E4M3FNUZ,F8_E5M2FNUZ,F8_E8M0,U64,U32). This expands whatparseSafetensorsMetadatacan type-safely represent/aggregate without changing parsing logic.Reviewed by Cursor Bugbot for commit bf4dcb9. Bugbot is set up for automated code reviews on this repo. Configure here.